Commit 7889f1ab authored by Pavel Vinokurov's avatar Pavel Vinokurov
Browse files

review notes

parent 309cd633
Showing with 9 additions and 3 deletions
+9 -3
......@@ -5,6 +5,7 @@ import com.cdek.transport.model.document.DocumentType;
/**
*
*/
//TODO refactor: javadoc
public abstract class CargoPlaceOperation extends DocumentOperation {
/**
......
......@@ -5,6 +5,7 @@ import com.cdek.transport.model.document.DocumentType;
/**
*
*/
//TODO refactor: javadoc
public abstract class DocumentOperation extends Operation {
/**
......
......@@ -50,6 +50,7 @@ public class SkedToDocumentMap {
documentToSkedMap.put(SORTER_INCOME, skedSorterIncome);
}
//TODO refactor: может убрать мапу и сделать javadoc
public static Map<String, Integer> get(DocumentType documentType) {
if (null == documentType) return new HashMap<>();
if (documentToSkedMap.containsKey(documentType)) {
......
......@@ -383,6 +383,8 @@ public class WarehouseServiceImpl implements WarehouseService {
return sked;
}
//TODO refactor: можно ли как объеденить все методы ниже
//TODO refactor: сделать protected
private PrimeIncomeCreateOrUpdate newPrimeIncomeCreateOrUpdate(Sked sked, String userCode) {
PrimeIncomeCreateOrUpdate operation;//Опись без идентификатора, значит создаем новую Опись и Документ Первичного Прихода
if (sked.getUuid() == null) {
......
......@@ -8,7 +8,6 @@ import com.cdek.transport.model.operation.CargoPlaceOperation;
* Контекст для обработчика при выполнении операций с документами
* Операция типа {@link CargoPlaceOperation}
*/
public class CargoPlaceOperationContext extends ExecutionContext {
protected Document document;
......
package com.cdek.warehouse.services.sked;
import com.cdek.transport.model.document.*;
import com.cdek.transport.model.document.Document;
import com.cdek.transport.model.sked.Sked;
import com.cdek.transport.model.sorter.document.SorterIncome;
/**
* Создает новую опись из Документа
......@@ -11,6 +10,7 @@ import com.cdek.transport.model.sorter.document.SorterIncome;
public interface SkedCreator {
//TODO refactor: javadoc
<E extends Document> Sked createSked(final E document);
<E extends Document> void setFields(final Sked sked, final E document);
......
......@@ -6,6 +6,7 @@ import com.cdek.transport.model.sked.Sked;
/**
*
*/
//TODO refactor:
public interface SkedDocumentMapper {
void setFields(final Sked sked, final Document document);
}
......@@ -9,6 +9,7 @@ import com.cdek.warehouse.services.sked.SkedDocumentMapper;
/**
*
*/
//TODO refactor: javadoc в маппере
public class SkedAcceptanceMapper extends SkedBaseDocumentMapper implements SkedDocumentMapper {
public SkedAcceptanceMapper(UserService userService) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment